Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(media_types): single-export files #3001

Merged
merged 5 commits into from
Dec 19, 2022
Merged

refactor(media_types): single-export files #3001

merged 5 commits into from
Dec 19, 2022

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 14, 2022

This is part of #2936, which aims for leaner dependencies and a more straightforward structure by only having one export per file within the media_types module.

@iuioiua iuioiua marked this pull request as ready for review December 14, 2022 02:05
@iuioiua iuioiua requested a review from kt3k as a code owner December 14, 2022 02:05
kt3k
kt3k approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@kt3k kt3k merged commit fda52ca into denoland:main Dec 19, 2022
@iuioiua iuioiua deleted the restructure-media_types branch December 19, 2022 10:02
@kt3k
Copy link
Member

kt3k commented Dec 19, 2022

Marked the commit as feat as new single export files can be considered as new features of media_types module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k