-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(encoding/csv): unified dir and move to single-export files #3024
Conversation
I don't think the original files with public exports should be deleted. Instead, a deprecation note should be added and the exported functions should come from the new function locations. This gives devs enough time to migrate. I did this here for the single-export restructure: https://github.com/denoland/deno_std/blob/7afe49284d0b5357eaf0f5668080cd26f13a1d8b/streams/buffer.ts |
Also, it might be a good idea to also action #2936 at the same time, if possible. |
@iuioiua good points. I added the re-exports file and split |
* | ||
* @example | ||
* ```ts | ||
* import { parse } from "https://deno.land/std@$STD_VERSION/encoding/csv/mod.ts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For imports within examples, it might be better to link to the most direct file. For example:
import { parse } from "https://deno.land/std@$STD_VERSION/encoding/csv/parse.ts";
Related: #2936. |
closing in favour of #2936 |
ref: #2538
This PR moves all csv related stuff into the same dir.
splits logic into single export files.
https://deno.land/std@$STD_VERSION/encoding/csv.ts
is deprecated.