Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(encoding/base58): fix base58 decoding missing the first byte #3275

Merged
merged 2 commits into from
Mar 24, 2023
Merged

fix(encoding/base58): fix base58 decoding missing the first byte #3275

merged 2 commits into from
Mar 24, 2023

Conversation

babiabeo
Copy link
Contributor

Fixes: #3272

@babiabeo babiabeo requested a review from kt3k as a code owner March 23, 2023 02:09
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@babiabeo babiabeo changed the title fix(encoding): fix base58 decoding missing the first byte fix(encoding/base58): fix base58 decoding missing the first byte Mar 23, 2023
kt3k
kt3k approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 5c6ee0e into denoland:main Mar 24, 2023
@babiabeo babiabeo deleted the fix-base58 branch March 24, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base58.decode missing first byte
3 participants
@babiabeo @CLAassistant @kt3k