Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): allow PropertyKey for groupBy #3461

Merged
merged 1 commit into from
Jul 5, 2023
Merged

feat(collections): allow PropertyKey for groupBy #3461

merged 1 commit into from
Jul 5, 2023

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner June 22, 2023 23:16
jsejcksn
jsejcksn approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@jsejcksn jsejcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Just curious: Did you actually need this in real code, or just see an opportunity to appropriately widen the generic type?

kt3k
kt3k approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 54a23fb into denoland:main Jul 5, 2023
@timreichen
Copy link
Contributor Author

Nice fix! Just curious: Did you actually need this in real code, or just see an opportunity to appropriately widen the generic type?

It actually needed to group by number in a project. The need to type cast first seemed redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@jsejcksn jsejcksn jsejcksn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timreichen @kt3k @jsejcksn