Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fmt): make printf respect NO_COLOR #3595

Merged
merged 3 commits into from
Sep 1, 2023
Merged

fix(fmt): make printf respect NO_COLOR #3595

merged 3 commits into from
Sep 1, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3575

@lino-levan lino-levan requested a review from kt3k as a code owner August 31, 2023 23:36
@github-actions github-actions bot added the fmt label Aug 31, 2023
kt3k
kt3k approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 717b7cc into denoland:main Sep 1, 2023
@lino-levan lino-levan deleted the fix-fmti branch September 1, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
fmt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[std/fmt/printf.ts] (s)printf doesn't honor NO_COLOR
3 participants
@lino-levan @kt3k @iuioiua