Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove readableStreamFromReader() & StringReader() in CSV stream test #3725

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 26, 2023

Removed the use of readableStreamFromReader and StringReader in csv stream parse tests since they are deprecated.
See #3718

@0scvr 0scvr requested a review from kt3k as a code owner October 26, 2023 08:40
@github-actions github-actions bot added the csv label Oct 26, 2023
csv/csv_parse_stream_test.ts Outdated Show resolved Hide resolved
@0scvr 0scvr force-pushed the cleanup-deprecated-apis branch from 2f37ac3 to 1f66bb6 Compare October 26, 2023 09:27
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Oscar 🙏🏾

@iuioiua iuioiua changed the title chore: remove readableStreamFromReader & StringReader in csv stream test chore: remove readableStreamFromReader() & StringReader() in CSV stream test Oct 26, 2023
@iuioiua iuioiua merged commit 7a0a7bb into denoland:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants