-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecation(log): rename warning()
to warn()
#4117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this done! Few nits.
Co-authored-by: Asher Gomez <[email protected]>
…chen/deno_std into log_rename_waring_to_warn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice.
Am I correct in understanding that this change is non-breaking?
Strictly speaking, if the users do any log analysis using |
Reverted |
@timreichen I don't see well what part is reverted? The below still seems printing import * as log from "./log/mod.ts";
log.warning("hi"); |
Sorry, seems like the commit wasn't pushed. Done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
ref: #4099