deprecation(log): move handlers to single-export files #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Jan 12, 2024
| const DEFAULT_FORMATTER = "{levelName} {msg}"; | ||
| export type FormatterFunction = (logRecord: LogRecord) => string; | ||
|
|
||
| export interface BaseHandlerOptions { |
There was a problem hiding this comment.
Note: this was previously HandlerOptions in handlers.ts.
| * | ||
| * This handler requires `--allow-write` permission on the log file. | ||
| */ | ||
| export class FileHandler extends BaseHandler { |
There was a problem hiding this comment.
Note: this used to extend WriterHandler in handlers.ts.
| @@ -137,6 +145,8 @@ interface FileHandlerOptions extends HandlerOptions { | |||
| * exists. | |||
| * | |||
| * This handler requires `--allow-write` permission on the log file. | |||
| * | |||
| * @deprecated (will be removed in 0.214.0) Import from {@link https://deno.land/std/log/file_handler.ts} instead. | |||
| */ | |||
| export class FileHandler extends WriterHandler { | |||
There was a problem hiding this comment.
Note: FileHandler extends BaseHandler in the new location.
| } | ||
| } | ||
|
|
||
| override log(msg: string) { |
There was a problem hiding this comment.
Note: this override is new. Shouldn't be breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4174