fix(expect): align toEqual to jest

[eryue0220]

This pr is to solve #4244

[kt3k]

Thanks for trying this, but this is significant breaking change to assertEquals and we can't merge this.

Fundamental issue here is that we share the same logic for assertEquals and expect().toEqual() but they have many incompatibilities in edge cases.

I think it's time to fork assertEquals for std/expect to safely diverge these 2 different APIs. Can you copy the necessary part of assertEquals under expect/ as internal utilities and apply these change to them?

[eryue0220]

Thanks for trying this, but this is significant breaking change to assertEquals and we can't merge this.

Fundamental issue here is that we share the same logic for assertEquals and expect().toEqual() but they have many incompatibilities in edge cases.

I think it's time to fork assertEquals for std/expect to safely diverge these 2 different APIs. Can you copy the necessary part of assertEquals under expect/ as internal utilities and apply these change to them?

Sure, I'll update this.

[eryue0220]

I‘ve update the std/expect, which will refers to toEqual and toStrictEqual. Besides fix the issues #4244 cases, this pr also aligns some other cases to jest.

[kt3k]

Looks great! Thanks for these changes.

I'd like to point one another thing. The below doesn't pass in Jest, but it passes with this change.

class A {}
class B {}
expect(new A()).toStrictEqual(new B());

I think we need to add constructor check if strictCheck is true.

[eryue0220]

Looks great! Thanks for these changes.

I'd like to point one another thing. The below doesn't pass in Jest, but it passes with this change.

class A {}
class B {}
expect(new A()).toStrictEqual(new B());

I think we need to add constructor() check if strictCheck is true.

Thank you,

I've fixed this problem.

[kt3k]

LGTM. This looks great improvements towards jest compatibility. Thanks for working on this!