Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore more test files from being published #4441

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Mar 5, 2024

This change:

  1. Includes **/*test.{ts,js} files to be published, as there's https://github.com/denoland/deno_std/blob/main/front_matter/test.ts that is part of the non-testing, public API.
  2. Adds further test files, like io/_test_common.ts to be excluded from publishing.

@iuioiua iuioiua requested a review from kt3k as a code owner March 5, 2024 05:26
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@iuioiua iuioiua merged commit 660e78e into main Mar 5, 2024
7 checks passed
@iuioiua iuioiua deleted the publish-ignore-more-test-files branch March 5, 2024 08:08
@lucacasonato
Copy link
Member

Why did we do this? Publishing test files to JSR is not a bad thing. Also this broke publishing of std/expect: _custom_equality_tester.ts matches the ignore regexp.

@kt3k
Copy link
Member

kt3k commented Mar 7, 2024

Thanks for catching!

Publishing test files to JSR is not a bad thing.

Ok. Let's include test files in published assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants