feat(expect): add expect.{closeTo, stringContaining, stringMatching}
#4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babiabeo
changed the title
expect.{closeTo, stringContaining, stringMatching}
iuioiua
suggested changes
Mar 24, 2024
expect/mod.ts
Outdated
Comment on lines
51
to
64
| * The asymmetric matchers are not yet fully supported: | ||
| * - Supported: | ||
| * - `expect.anything` | ||
| * - `expect.any` | ||
| * - `expect.arrayContaining` | ||
| * - `expect.not.arrayContaining` | ||
| * - `expect.closedTo` | ||
| * - `expect.stringContaining` | ||
| * - `expect.not.stringContaining` | ||
| * - `expect.stringMatching` | ||
| * - `expect.not.stringMatching` | ||
| * - Not supported: | ||
| * - `expect.objectContaining` | ||
| * - `expect.not.objectContaining` |
There was a problem hiding this comment.
This doesn't make sense. Within a list of symbols that are not fully supported, there's a list of symbols that are supported. Can you please correct and clarify?
expect/mod.ts
Outdated
Comment on lines
66
to
73
| * The uitlities are not yet fully supported: | ||
| * - Supported: | ||
| * - `expect.addEqualityTester` | ||
| * - `expect.extend` | ||
| * - Not supported: | ||
| * - `expect.assertions` | ||
| * - `expect.hasAssertions` | ||
| * - `expect.addSnapshotSerializer` |
There was a problem hiding this comment.
Ditto. This doesn't make sense for the same reason as the above list. Please correct and clarify.
|
Let me know if these changes make sense to you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds these following asymmetric matchers:
Ref: #3964