-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecation(expect): rename addSnapshotSerializers
to addSnapshotSerializer
#4582
deprecation(expect): rename addSnapshotSerializers
to addSnapshotSerializer
#4582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4582 +/- ##
==========================================
- Coverage 91.23% 91.00% -0.24%
==========================================
Files 478 476 -2
Lines 41465 37692 -3773
Branches 5225 5384 +159
==========================================
- Hits 37832 34301 -3531
+ Misses 3568 3337 -231
+ Partials 65 54 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thank you.
expect/expect.ts
Outdated
@@ -199,7 +199,11 @@ export function expect(value: unknown, customMessage?: string): Expected { | |||
} | |||
|
|||
expect.addEqualityTesters = addCustomEqualityTesters; | |||
/** | |||
* @deprecated (will be removed in 1.0.0) Use {@linkcode expect.addSnapshotSerializer} instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std/expect
is unstable. Let's remove this in 0.226.0.
cbed7dd
to
ca7c82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
This PR renames
expect.addSnapshotSerializers
toexpect.addSnapshotSerializer
to match Jest's naming.