Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(expect): rename addSnapshotSerializers to addSnapshotSerializer #4582

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Apr 14, 2024

This PR renames expect.addSnapshotSerializers to expect.addSnapshotSerializer to match Jest's naming.

@uki00a uki00a requested a review from kt3k as a code owner April 14, 2024 09:16
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.00%. Comparing base (a6fe34b) to head (ca7c82b).
Report is 205 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4582      +/-   ##
==========================================
- Coverage   91.23%   91.00%   -0.24%     
==========================================
  Files         478      476       -2     
  Lines       41465    37692    -3773     
  Branches     5225     5384     +159     
==========================================
- Hits        37832    34301    -3531     
+ Misses       3568     3337     -231     
+ Partials       65       54      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you.

expect/expect.ts Outdated
@@ -199,7 +199,11 @@ export function expect(value: unknown, customMessage?: string): Expected {
}

expect.addEqualityTesters = addCustomEqualityTesters;
/**
* @deprecated (will be removed in 1.0.0) Use {@linkcode expect.addSnapshotSerializer} instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std/expect is unstable. Let's remove this in 0.226.0.

@uki00a uki00a force-pushed the rename-addSnapshotSerializers-to-addSnapshotSerializer branch from cbed7dd to ca7c82b Compare April 15, 2024 00:43
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit e299c8b into denoland:main Apr 15, 2024
13 checks passed
@uki00a uki00a deleted the rename-addSnapshotSerializers-to-addSnapshotSerializer branch April 15, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants