Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(collections): complete documentation #4664

Merged
merged 14 commits into from
May 6, 2024
Merged

docs(collections): complete documentation #4664

merged 14 commits into from
May 6, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 2, 2024 •
edited
Loading

Towards #4647

@github-actions github-actions bot added the fs label May 6, 2024
@github-actions github-actions bot removed the fs label May 6, 2024
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (2f59341) to head (304d4a3).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4664      +/-   ##
==========================================
- Coverage   91.36%   91.36%   -0.01%     
==========================================
  Files         477      477              
  Lines       37334    37332       -2     
  Branches     5325     5323       -2     
==========================================
- Hits        34109    34107       -2     
  Misses       3164     3164              
  Partials       61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua mentioned this pull request May 6, 2024
Closed
10 tasks
@iuioiua iuioiua marked this pull request as ready for review May 6, 2024 06:51
@iuioiua iuioiua requested a review from kt3k as a code owner May 6, 2024 06:51
@iuioiua iuioiua enabled auto-merge (squash) May 6, 2024 06:58
kt3k
kt3k reviewed May 6, 2024
View reviewed changes
collections/join_to_string.ts Outdated Show resolved Hide resolved
kt3k
kt3k reviewed May 6, 2024
View reviewed changes
collections/max_of.ts Outdated Show resolved Hide resolved
kt3k
kt3k reviewed May 6, 2024
View reviewed changes
collections/min_of.ts Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from kt3k May 6, 2024 07:41
kt3k
kt3k approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great!

@iuioiua iuioiua merged commit 5e99c21 into main May 6, 2024
12 checks passed
@iuioiua iuioiua deleted the collections-docs-2 branch May 6, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k