Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data-structures): improve documentation #4793

Merged
merged 7 commits into from
May 22, 2024
Merged

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented May 21, 2024

This commit completes documentation for the @std/data-structures module.

@lucacasonato lucacasonato requested a review from kt3k as a code owner May 21, 2024 10:23
@lucacasonato lucacasonato force-pushed the data_structures_docs branch from ba1e8f2 to e2549b7 Compare May 21, 2024 10:24
@lucacasonato lucacasonato changed the title BREAKING(data_structures): docs & private internals BREAKING(data-structures): docs & private internals May 21, 2024
@lucacasonato lucacasonato force-pushed the data_structures_docs branch from e2549b7 to 6aecb07 Compare May 21, 2024 10:26
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (e0886f7) to head (b2c87fb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4793   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files         486      486           
  Lines       41329    41353   +24     
  Branches     5321     5321           
=======================================
+ Hits        38000    38024   +24     
  Misses       3272     3272           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacasonato lucacasonato force-pushed the data_structures_docs branch 3 times, most recently from 058ae7f to 0a0c65b Compare May 21, 2024 10:31
This commit completes documentation for the
`@std/data-structures` module.
@lucacasonato lucacasonato force-pushed the data_structures_docs branch from 0a0c65b to cea9a78 Compare May 21, 2024 12:36
@lucacasonato lucacasonato changed the title BREAKING(data-structures): docs & private internals docs(data-structures): improve documentation May 21, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@iuioiua
Copy link
Contributor

iuioiua commented May 22, 2024

Sorry, it looks like a rebase is needed after the revert.

@iuioiua
Copy link
Contributor

iuioiua commented May 22, 2024

Let me submit a PR to remove the leaky abstractions.

@kt3k
Copy link
Member

kt3k commented May 22, 2024

Let me submit a PR to remove the leaky abstractions.

I'll land this for now when CI passed. I think that makes further work easier

@kt3k kt3k merged commit 345854c into main May 22, 2024
12 checks passed
@kt3k kt3k deleted the data_structures_docs branch May 22, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants