Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(crypto): improve docs #4797

Closed
wants to merge 7 commits into from
Closed

Conversation

littledivy
Copy link
Member

No description provided.

@littledivy littledivy requested a review from kt3k as a code owner May 21, 2024 11:33
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (83991c7) to head (760b32b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4797   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         487      487           
  Lines       41539    41540    +1     
  Branches     5365     5365           
=======================================
+ Hits        38207    38208    +1     
  Misses       3274     3274           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacasonato
Copy link
Member

StdSubtleCrypto is lacking significant documentation: StdSubtleCrypto.digest and StdSubtleCrypto.digestSync are very incomplete and have no usage samples at all.

@littledivy
Copy link
Member Author

Thanks for pointing out, I was solely relying on lint:docs to yell at me :)

@kt3k
Copy link
Member

kt3k commented May 29, 2024

closing in favor of #4884

@kt3k kt3k closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants