Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ini): remove unused ParseOptions.assignment property #4816

Merged
merged 1 commit into from
May 23, 2024

Conversation

dsherret
Copy link
Member

This property is not used.

@dsherret dsherret requested a review from kt3k as a code owner May 21, 2024 19:41
@github-actions github-actions bot added the ini label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (0ef767f) to head (3637df6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4816      +/-   ##
==========================================
- Coverage   91.94%   91.93%   -0.01%     
==========================================
  Files         486      486              
  Lines       41327    41327              
  Branches     5321     5321              
==========================================
- Hits        37998    37996       -2     
- Misses       3272     3274       +2     
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsherret
Copy link
Member Author

@iuioiua no, those are formatting options. This is parse options.

@dsherret dsherret changed the title refactor(ini): remove unused assignment property BREAKING(ini): remove unused assignment property May 22, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my misunderstanding. This can be marked as a fix. It shouldn't break anything.

@iuioiua iuioiua changed the title BREAKING(ini): remove unused assignment property fix(ini): remove unused ParseOptions.assignment property May 22, 2024
@dsherret dsherret merged commit e7c5c6a into denoland:main May 23, 2024
14 checks passed
@dsherret dsherret deleted the refactor_ini_not_used_assignment branch May 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants