fix(cli): reduce flicker in spinner render function #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
reviewed
May 22, 2024
Comment on lines
+145
to
+148
| const writeData = new Uint8Array(LINE_CLEAR.length + frame.length); | ||
| writeData.set(LINE_CLEAR); | ||
| writeData.set(frame, LINE_CLEAR.length); | ||
| Deno.stdout.writeSync(writeData); |
There was a problem hiding this comment.
An alternative using concat():
Suggested change
| const writeData = new Uint8Array(LINE_CLEAR.length + frame.length); | |
| writeData.set(LINE_CLEAR); | |
| writeData.set(frame, LINE_CLEAR.length); | |
| Deno.stdout.writeSync(writeData); | |
| Deno.stdout.writeSync(concat([LINE_CLEAR, frame])); |
There was a problem hiding this comment.
Oh, I missed that this was in a separate package. I'm not sure it's worth causing another package load to occur when importing this module.
Co-authored-by: Asher Gomez <[email protected]>
This reverts commit 2930525.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4835 +/- ##
==========================================
- Coverage 91.97% 91.97% -0.01%
==========================================
Files 486 487 +1
Lines 41459 41542 +83
Branches 5360 5365 +5
==========================================
+ Hits 38131 38207 +76
- Misses 3270 3277 +7
Partials 58 58 ☔ View full report in Codecov by Sentry. |
iuioiua
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.