Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(streams): improve docs for stabilization #4852

Merged
merged 37 commits into from
May 28, 2024

Conversation

magurotuna
Copy link
Member

This commit improves docs of the streams module.

Towards #3764

@magurotuna magurotuna requested a review from kt3k as a code owner May 24, 2024 09:44
@magurotuna magurotuna requested a review from crowlKats as a code owner May 24, 2024 09:44
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.35%. Comparing base (d13ef17) to head (fd5b75b).

Files Patch % Lines
streams/buffer.ts 95.00% 1 Missing ⚠️
streams/delimiter_stream.ts 75.00% 1 Missing ⚠️
streams/text_delimiter_stream.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4852      +/-   ##
==========================================
- Coverage   92.35%   92.35%   -0.01%     
==========================================
  Files         487      487              
  Lines       41539    41562      +23     
  Branches     5405     5405              
==========================================
+ Hits        38363    38384      +21     
- Misses       3120     3122       +2     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k mentioned this pull request May 24, 2024
38 tasks
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

streams/early_zip_readable_streams.ts Outdated Show resolved Hide resolved
@magurotuna magurotuna merged commit 9c3c53e into denoland:main May 28, 2024
12 checks passed
@magurotuna magurotuna deleted the magurotuna/streams-doc branch May 28, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants