Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(encoding): remove deprecated VarInt APIs #4864

Merged
merged 2 commits into from
May 30, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 28, 2024

This should only be merged right before @std/[email protected].

@iuioiua iuioiua requested a review from kt3k as a code owner May 28, 2024 02:37
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (9c3c53e) to head (458488e).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4864      +/-   ##
==========================================
- Coverage   92.35%   91.95%   -0.41%     
==========================================
  Files         487      487              
  Lines       41562    38868    -2694     
  Branches     5405     5388      -17     
==========================================
- Hits        38384    35740    -2644     
+ Misses       3122     3072      -50     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit f8f5444 into main May 30, 2024
12 checks passed
@iuioiua iuioiua deleted the remove-deprecated-varint branch May 30, 2024 08:03
@iuioiua iuioiua mentioned this pull request Jun 2, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants