Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(uuid): rename V1Options to GenerateOptions #4872

Merged
merged 2 commits into from
May 29, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 29, 2024

The convention in this codebase is for options interfaces to be named XOptions, where X is the name of the symbol that the options interface belongs to.

@github-actions github-actions bot added the uuid label May 29, 2024
@iuioiua iuioiua marked this pull request as ready for review May 29, 2024 06:33
@iuioiua iuioiua requested a review from kt3k as a code owner May 29, 2024 06:33
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (0b95598) to head (b4f52f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4872      +/-   ##
==========================================
- Coverage   92.36%   92.36%   -0.01%     
==========================================
  Files         488      488              
  Lines       41604    41603       -1     
  Branches     5405     5405              
==========================================
- Hits        38426    38425       -1     
  Misses       3122     3122              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Contributor Author

iuioiua commented May 29, 2024

I realize we don't export this interface from uuid/mod.ts. How do we do that again?

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Makes sense to me. LGTM

@iuioiua iuioiua merged commit a0b0f4c into main May 29, 2024
12 checks passed
@iuioiua iuioiua deleted the uuid-v1-generate-options branch May 29, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants