BREAKING(uuid): remove v1.generate() signature with buf and offset parameters and number[] return type
#4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4877 +/- ##
==========================================
- Coverage 92.12% 92.12% -0.01%
==========================================
Files 487 487
Lines 38747 38745 -2
Branches 5391 5388 -3
==========================================
- Hits 35697 35695 -2
Misses 2994 2994
Partials 56 56 ☔ View full report in Codecov by Sentry. |
|
This probably makes sense. Also optional 3 arguments breaks the style guide of the standard library (There should be only one optional argument at most https://docs.deno.com/runtime/manual/references/contributing/style_guide#exported-functions-max-2-args-put-the-rest-into-an-options-object |
iuioiua
changed the title
v1.generate()v1.generate() signature with buf and offset parameters
iuioiua
changed the title
v1.generate() signature with buf and offset parametersv1.generate() signature with buf and offset parameters and number[] return type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the optional
bufandoffsetarguments andnumber[]return type fromv1.generate(). These settings are unneeded in almost all cases and gave the function a shape that differed from the othergenerate()functions within@std/uuid.