BREAKING(path): remove GlobToRegExpOptions.os
and OSType
export
#4928
+60
−93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
This change removes the
os
property from theGlobToRegExpOptions
interface and theoptions
interface forglobToRegExp()
and also removesOSType
from the public API.Why this change was made
The
os
property controlled which OSglobToRegExp()
worked for. More specifically, it controlled how it delimited paths, as path delimiters change between OSs. This was the only function in@std/path
that had this functionality, as other functions instead detected the OS of the current machine and then used the appropriate OS-specific logic. Since theos
property had theOSType
type, it's now been removed from the public API.Migration guide
If you'd like
globToRegExp()
to automatically work for the current machine's OS and didn't use theos
option, there's no need to change your code.However, if you'd like to use have
globToRegExp()
work for a specific OS, import the OS-specific version of the function. For POSIX systems:For Windows systems: