-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(path): release [email protected]
#4951
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4951 +/- ##
=======================================
Coverage 92.17% 92.18%
=======================================
Files 487 487
Lines 38732 38765 +33
Branches 5386 5394 +8
=======================================
+ Hits 35702 35734 +32
- Misses 2974 2975 +1
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -39,7 +39,7 @@ | |||
"@std/media-types": "jsr:@std/media-types@^1.0.0-rc.1", | |||
"@std/msgpack": "jsr:@std/msgpack@^0.224.2", | |||
"@std/net": "jsr:@std/net@^0.224.2", | |||
"@std/path": "jsr:@std/path@^0.225.2", | |||
"@std/path": "jsr:@std/path@1.0.0-rc.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Let's land this first and keep discussing #4954 during RC (Breaking changes during RC versions are common practice to my knowledge). |
Frankly, breaking changes during the release candidate phase seems to conflict with the objective of a release candidate, and I disagree with it. Nevertheless, I'm merging this PR so we can progress with stabilization. |
Toward #4922