Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(webgpu): cleanup use of @std/assert #4978

Merged
merged 3 commits into from
Jun 5, 2024
Merged

refactor(webgpu): cleanup use of @std/assert #4978

merged 3 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 5, 2024

Towards #4865

@iuioiua iuioiua requested review from kt3k and crowlKats as code owners June 5, 2024 09:02
@github-actions github-actions bot added the webgpu label Jun 5, 2024
@iuioiua iuioiua mentioned this pull request Jun 5, 2024
Closed
13 tasks
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.10%. Comparing base (48440b8) to head (a58f859).

❗ Current head a58f859 differs from pull request most recent head 1e6a499

Please upload reports for the commit 1e6a499 to get more accurate results.

Files Patch % Lines
webgpu/texture_with_data.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4978      +/-   ##
==========================================
- Coverage   92.10%   92.10%   -0.01%     
==========================================
  Files         487      487              
  Lines       38750    38749       -1     
  Branches     5412     5412              
==========================================
- Hits        35689    35688       -1     
  Misses       3004     3004              
  Partials       57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kt3k
kt3k approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) June 5, 2024 22:06
@iuioiua iuioiua merged commit e1e7c09 into main Jun 5, 2024
10 checks passed
@iuioiua iuioiua deleted the webgpu-clean-assert branch June 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

Assignees
No one assigned
Labels
webgpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k