Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ini): improve ini docs #5020

Merged
merged 7 commits into from
Jun 11, 2024
Merged

docs(ini): improve ini docs #5020

merged 7 commits into from
Jun 11, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 10, 2024

part of #3764

@github-actions github-actions bot added the ini label Jun 10, 2024
@kt3k kt3k mentioned this pull request Jun 10, 2024
38 tasks
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (2d5b5b4) to head (97449ff).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5020   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         487      487           
  Lines       38773    38786   +13     
  Branches     5428     5428           
=======================================
+ Hits        35689    35702   +13     
  Misses       3027     3027           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k marked this pull request as ready for review June 10, 2024 11:11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocker: is there a reason why these snippets are missing assertions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Now these use assertions.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kt3k kt3k merged commit ec73b76 into denoland:main Jun 11, 2024
12 checks passed
@kt3k kt3k deleted the improve-ini-docs branch June 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants