Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(msgpack): complete documentation #5029

Merged
merged 1 commit into from
Jun 12, 2024
Merged

docs(msgpack): complete documentation #5029

merged 1 commit into from
Jun 12, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 11, 2024

Towards #3764 and #5000

@iuioiua iuioiua requested a review from kt3k as a code owner June 11, 2024 21:24
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (1f359c4) to head (daaf2b2).

Files Patch % Lines
msgpack/decode.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5029   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         487      487           
  Lines       38798    38798           
  Branches     5429     5429           
=======================================
  Hits        35714    35714           
  Misses       3027     3027           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua iuioiua merged commit f7ae2aa into main Jun 12, 2024
12 checks passed
@iuioiua iuioiua deleted the msgpack-docs-2 branch June 12, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants