Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(csv): minor cleanup #5166

Merged
merged 5 commits into from
Jul 2, 2024
Merged

refactor(csv): minor cleanup #5166

merged 5 commits into from
Jul 2, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 27, 2024

Omits the previously faulty changes made to CsvStringifyStream.

@iuioiua iuioiua requested a review from kt3k as a code owner June 27, 2024 06:09
@github-actions github-actions bot added the csv label Jun 27, 2024
@iuioiua iuioiua enabled auto-merge (squash) June 27, 2024 06:10
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (b15707d) to head (31a9ad4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5166      +/-   ##
==========================================
- Coverage   94.98%   94.98%   -0.01%     
==========================================
  Files         460      460              
  Lines       38059    38055       -4     
  Branches     5543     5544       +1     
==========================================
- Hits        36150    36146       -4     
  Misses       1868     1868              
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d983137 into main Jul 2, 2024
15 checks passed
@iuioiua iuioiua deleted the csv-clean-2 branch July 2, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants