Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(semver): release [email protected] #5220

Merged
merged 3 commits into from
Jul 31, 2024
Merged

chore(semver): release [email protected] #5220

merged 3 commits into from
Jul 31, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 1, 2024

To be merged July 30.

Closes #5013

@iuioiua iuioiua requested a review from kt3k as a code owner July 1, 2024 04:07
@github-actions github-actions bot added the semver label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (9253dcb) to head (8b13c02).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5220   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         465      465           
  Lines       37759    37759           
  Branches     5579     5579           
=======================================
  Hits        36432    36432           
  Misses       1285     1285           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k requested a review from dsherret July 29, 2024 03:19
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Only question I have is why can canParse possibly throw, but tryParse can't?

@kt3k
Copy link
Member

kt3k commented Jul 31, 2024

Only question I have is why can canParse possibly throw, but tryParse can't?

Sounds a good point. I don't think the current state is intentional. Do you think it's good idea to align tryParse to canParse?

@dsherret
Copy link
Member

Yeah I wouldn't expect either to ever throw.

@iuioiua iuioiua merged commit b328265 into main Jul 31, 2024
13 checks passed
@iuioiua iuioiua deleted the semver-1 branch July 31, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stabilize @std/semver
3 participants