Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove DirectiveHandler type #5247

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

timreichen
Copy link
Contributor

  • removes DirectiveHandler type and makes directiveHandlers standalone functions

@timreichen timreichen requested a review from kt3k as a code owner July 2, 2024 09:07
@github-actions github-actions bot added the yaml label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (41385c0) to head (2660c51).

Current head 2660c51 differs from pull request most recent head 1abd899

Please upload reports for the commit 1abd899 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5247      +/-   ##
==========================================
- Coverage   95.46%   95.38%   -0.08%     
==========================================
  Files         460      460              
  Lines       37959    37963       +4     
  Branches     5535     5532       -3     
==========================================
- Hits        36237    36212      -25     
- Misses       1680     1709      +29     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title refactor(yaml): remove DirectiveHandler type refactor(yaml): remove DirectiveHandler type Jul 2, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) July 2, 2024 09:32
@iuioiua iuioiua merged commit 8420b13 into denoland:main Jul 2, 2024
13 checks passed
@timreichen timreichen deleted the yaml-refactor-directive-handlers branch August 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants