Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): add peek() and next() to LoaderState #5276

Merged
merged 10 commits into from
Jul 3, 2024

Conversation

timreichen
Copy link
Contributor

  • adds peek() and next() methods to LoaderState

@timreichen timreichen requested a review from kt3k as a code owner July 3, 2024 07:39
@github-actions github-actions bot added the yaml label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.72%. Comparing base (9127978) to head (83cb304).

Files Patch % Lines
yaml/_loader.ts 89.28% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5276   +/-   ##
=======================================
  Coverage   95.72%   95.72%           
=======================================
  Files         457      457           
  Lines       37951    37955    +4     
  Branches     5560     5560           
=======================================
+ Hits        36327    36331    +4     
  Misses       1583     1583           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Yoshiya Hinosawa <[email protected]>
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@iuioiua iuioiua changed the title refactor(yaml): add peek() and next() refactor(yaml): add peek() and next() to LoaderState Jul 3, 2024
@iuioiua iuioiua merged commit a78d874 into denoland:main Jul 3, 2024
15 checks passed
@timreichen timreichen deleted the yaml-add-peek-and-next branch July 3, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants