Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(ini): make IniMap private #5351

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 8, 2024

This PR makes IniMap class private.

We didn't find any usage of IniMap. So this PR shouldn't affect any users.

What's changed

IniMap has been removed

Motivation

We didn't find any usage, any feedback to the API, and we decided to remove this API.

Migration

There's no migration path. Let us know if you use this API.

@github-actions github-actions bot added the ini label Jul 8, 2024
@kt3k kt3k marked this pull request as draft July 8, 2024 07:35
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (a0b4103) to head (93d9866).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5351      +/-   ##
==========================================
+ Coverage   95.94%   96.24%   +0.29%     
==========================================
  Files         458      458              
  Lines       37849    37848       -1     
  Branches     5582     5608      +26     
==========================================
+ Hits        36314    36426     +112     
+ Misses       1494     1381     -113     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title BREAKING(ini): make IniMap private BREAKING(ini): make IniMap private Jul 8, 2024
@kt3k kt3k marked this pull request as ready for review July 9, 2024 03:27
@kt3k kt3k requested a review from iuioiua July 9, 2024 03:28
@kt3k kt3k merged commit e710e61 into denoland:main Jul 9, 2024
13 checks passed
@kt3k kt3k deleted the make-ini-map-private branch July 9, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants