Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streams): strictly define toJson() and toText() input #5517

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 23, 2024

Includes documentation clarifications and test cleanups. See discussion in #5079.

@iuioiua iuioiua requested review from kt3k and crowlKats as code owners July 23, 2024 03:11
@iuioiua iuioiua enabled auto-merge (squash) July 23, 2024 03:11
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (5cff014) to head (e26cf8e).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5517   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         465      465           
  Lines       37760    37760           
  Branches     5574     5574           
=======================================
  Hits        36364    36364           
  Misses       1354     1354           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit a04a2ed into main Jul 23, 2024
17 checks passed
@iuioiua iuioiua deleted the streams-json-text-impr branch July 23, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants