-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(text/unstable): add slugify()
function
#5646
Conversation
slugify()
functionslugify()
function
slugify()
functionslugify()
function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5646 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 475 476 +1
Lines 38489 38502 +13
Branches 5588 5588
=======================================
+ Hits 37048 37061 +13
Misses 1399 1399
Partials 42 42 ☔ View full report in Codecov by Sentry. |
@marvinhagemeister @kt3k The current draft implements the char replacement map from |
slugify()
functionslugify()
function
PTAL @marvinhagemeister @kt3k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. | ||
|
||
/** | ||
* **UNSTABLE**: New API, yet to be vetted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, this being the first paragraph means it's used as the summary for this symbol. Please ensure the description is always first for symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same as what CLI does. https://docs.deno.com/api/deno/all_symbols
If you suggest something different, I think you should also suggest the same to CLI docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref: #5627