Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(assert): Add additional example in assertObjectMatch docs #5703

Merged
merged 1 commit into from
Aug 19, 2024
Merged

docs(assert): Add additional example in assertObjectMatch docs #5703

merged 1 commit into from
Aug 19, 2024

Conversation

kevin-zou
Copy link
Contributor

As title describes, add an example in usage of assertObjectMatch to show that the expected object can be a subset of the actual object but the inverse will result in an assertion failure.

Discussed in #5682

@kevin-zou kevin-zou requested a review from kt3k as a code owner August 17, 2024 03:39
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kevin-zou kevin-zou changed the title Add additional example in assertObjectMatch docs docs(assert): Add additional example in assertObjectMatch docs Aug 17, 2024
kt3k
kt3k approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice! Thanks

@kt3k kt3k merged commit cb3dd2b into denoland:main Aug 19, 2024
11 of 12 checks passed
@kevin-zou kevin-zou deleted the assertObjectMatch-docs branch August 19, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
assert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin-zou @CLAassistant @kt3k