refactor(archive,cache,datetime,fmt,front-matter): align error messages to the style guide #5706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligns the error messages in the `front_matter` folder to match the style guide. denoland#5574
Aligns the error messages in the `cache` folder to match the style guide. denoland#5574
Aligns the error messages in the `archive` folder to match the style guide. denoland#5574
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5706 +/- ##
==========================================
- Coverage 96.28% 96.25% -0.04%
==========================================
Files 474 474
Lines 38383 38403 +20
Branches 5578 5586 +8
==========================================
+ Hits 36957 36964 +7
- Misses 1384 1397 +13
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Aligns the error messages in the `datetime` folder to match the style guide. denoland#5574
Aligns the error messages in the `fmt` folder to match the style guide. denoland#5574
kt3k
changed the title
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
fmt/printf.ts
Outdated
| @@ -611,7 +621,10 @@ class Printf { | |||
| prefix += "0x"; | |||
| break; | |||
| default: | |||
| throw new Error("cannot handle base: " + radix); | |||
| throw new Error( | |||
| "Format number only supports radix 2, 8 and 16: cannot handle radix " + | |||
There was a problem hiding this comment.
I'd suggest the below
Suggested change
| "Format number only supports radix 2, 8 and 16: cannot handle radix " + | |
| `Cannot handle the radix ${radix}. Only 2, 8, 16 are supported` |
because of the rule Message should state the action that lead to the error
There was a problem hiding this comment.
I've merged a slightly different version of this that reads: Cannot handle the radix ${radix}: only 2, 8, 16 are supported
kt3k
reviewed
Aug 20, 2024
fmt/printf.ts
Outdated
| @@ -881,7 +898,7 @@ class Printf { | |||
| } | |||
| default: | |||
| throw new Error( | |||
| "currently only number and string are implemented for hex", | |||
| `Only "number" and "string" are implemented for hex formatting: ${typeof val} is not currently supported`, | |||
There was a problem hiding this comment.
Suggested change
| `Only "number" and "string" are implemented for hex formatting: ${typeof val} is not currently supported`, | |
| `Cannot format hex. Only number and string are supported for hex formatting: ${typeof val} is given, |
There was a problem hiding this comment.
I've committed a slightly different version of this that reads: Cannot format hex, only number and string are supported for hex formatting: ${typeof val} is given
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
kt3k
reviewed
Aug 20, 2024
irbull
changed the title
irbull
commented
Aug 20, 2024
irbull
commented
Aug 20, 2024
Commit suggestions by @kt3k Co-authored-by: Yoshiya Hinosawa <[email protected]>
irbull
commented
Aug 20, 2024
Fixed a syntax error
irbull
commented
Aug 20, 2024
irbull
commented
Aug 20, 2024
irbull
commented
Aug 20, 2024
Update test cases to match the new format
kt3k
reviewed
Aug 21, 2024
kt3k
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns error messages in
archive,cache,front_matter,date_timeandfmtfolders.