Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): cleanup Schema #5715

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

timreichen
Copy link
Contributor

Changes
This PR makes Schema an interface instead of a class.
As it turns out, compileList() just combines the implicit types with implicit types of the include schema, same with explicit types.

@timreichen timreichen requested a review from kt3k as a code owner August 18, 2024 16:26
@github-actions github-actions bot added the yaml label Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (75cb767) to head (e8c14d9).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5715    +/-   ##
========================================
  Coverage   96.26%   96.27%            
========================================
  Files         477      473     -4     
  Lines       38512    38366   -146     
  Branches     5589     5574    -15     
========================================
- Hits        37072    36935   -137     
+ Misses       1398     1389     -9     
  Partials       42       42            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit 8cb8496 into denoland:main Aug 20, 2024
13 checks passed
@timreichen timreichen deleted the yaml-cleanup-compileList branch August 20, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants