Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): make BaseHandler abstract #5737

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Aug 20, 2024

Ref: #5702
Changes
This PR makes the BaseHandler and log() method abstract.
It removes the obsolete override for log() in FileHandler and ConsoleHandler.

@timreichen timreichen requested a review from kt3k as a code owner August 20, 2024 07:09
@github-actions github-actions bot added the log label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.29%. Comparing base (d6fde64) to head (f8b1750).
Report is 27 commits behind head on main.

Files Patch % Lines
log/console_handler.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5737   +/-   ##
=======================================
  Coverage   96.28%   96.29%           
=======================================
  Files         474      474           
  Lines       38387    38386    -1     
  Branches     5578     5578           
=======================================
  Hits        36962    36962           
+ Misses       1383     1382    -1     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit afb9a4f into denoland:main Aug 22, 2024
16 checks passed
@timreichen timreichen deleted the log-make-BaseHandler-abstract branch August 22, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants