Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): cleanup detectType() #5759

Merged
merged 12 commits into from
Aug 25, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner August 21, 2024 20:18
@github-actions github-actions bot added the yaml label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (b91817f) to head (3757fff).
Report is 3 commits behind head on main.

Files Patch % Lines
yaml/_dumper_state.ts 80.76% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5759   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         479      479           
  Lines       38719    38719           
  Branches     5614     5614           
=======================================
+ Hits        37262    37263    +1     
+ Misses       1416     1415    -1     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit 7f78e95 into denoland:main Aug 25, 2024
16 checks passed
@timreichen timreichen deleted the yaml-cleanup-detectType branch December 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants