Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): inline readLineBreak() #5783

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

timreichen
Copy link
Contributor

Ref: #5749

@timreichen timreichen requested a review from kt3k as a code owner August 22, 2024 21:50
@github-actions github-actions bot added the yaml label Aug 22, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.25%. Comparing base (f14f74b) to head (7c65c08).
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 83.33% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5783   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files         481      481           
  Lines       38738    38738           
  Branches     5615     5615           
=======================================
  Hits        37288    37288           
  Misses       1409     1409           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit a81742a into denoland:main Aug 22, 2024
16 checks passed
@timreichen timreichen deleted the yaml-inline-readLineBreak branch August 24, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants