Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(testing): align additional error messages #5810

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Aug 24, 2024

Aligns the error messages in the testing folder to match the style guide. Only errors thrown during test setup are updated, errors thrown during test execution are not updated.

#5574

Aligns the error messages in the `testing` folder to match the style
guide. Only errors thrown during test setup are updated, errors thrown
during test execution are not updated.

denoland#5574
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (c817a5a) to head (46f1d97).
Report is 19 commits behind head on main.

Files Patch % Lines
testing/bdd.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5810      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files         480      480              
  Lines       38748    38773      +25     
  Branches     5616     5621       +5     
==========================================
+ Hits        37291    37312      +21     
- Misses       1416     1420       +4     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit 73987a1 into denoland:main Aug 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants