Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(yaml): inline writeFoldedLines() #5812

Merged
merged 1 commit into from
Aug 25, 2024
Merged

refactor(yaml): inline writeFoldedLines() #5812

merged 1 commit into from
Aug 25, 2024

Conversation

timreichen
Copy link
Contributor

Ref: #5749

@timreichen timreichen requested a review from kt3k as a code owner August 25, 2024 06:54
@github-actions github-actions bot added the yaml label Aug 25, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (a549b78) to head (d826d43).
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 60.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5812      +/-   ##
==========================================
- Coverage   96.24%   96.21%   -0.03%     
==========================================
  Files         479      479              
  Lines       38720    38720              
  Branches     5615     5616       +1     
==========================================
- Hits        37266    37256      -10     
- Misses       1413     1423      +10     
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iuioiua
iuioiua approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iuioiua iuioiua merged commit 7f5318d into denoland:main Aug 25, 2024
16 checks passed
@timreichen timreichen deleted the yaml-inline-writeFoldedLines branch December 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua