Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): inline readPlainScalar() #5813

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

timreichen
Copy link
Contributor

Ref: #5749

@timreichen timreichen requested a review from kt3k as a code owner August 25, 2024 08:41
@github-actions github-actions bot added the yaml label Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 79.56989% with 19 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (b91817f) to head (12aaece).
Report is 2 commits behind head on main.

Files Patch % Lines
yaml/_loader_state.ts 79.56% 18 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5813      +/-   ##
==========================================
- Coverage   96.23%   96.23%   -0.01%     
==========================================
  Files         479      479              
  Lines       38719    38716       -3     
  Branches     5614     5615       +1     
==========================================
- Hits        37262    37259       -3     
  Misses       1416     1416              
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@iuioiua iuioiua merged commit abfa1a2 into denoland:main Aug 25, 2024
16 checks passed
@timreichen timreichen deleted the yaml-inline-readPlainScalar branch December 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants