Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): use isObject() #5822

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Aug 26, 2024

Changes
This PR removes isArray() in combination with isObject(), because array is an object.

@timreichen timreichen requested a review from kt3k as a code owner August 26, 2024 07:32
@timreichen timreichen changed the title refactory() refactor(yaml): use isObject() Aug 26, 2024
@github-actions github-actions bot added the yaml label Aug 26, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (3666d84) to head (0409258).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5822      +/-   ##
==========================================
- Coverage   96.26%   96.25%   -0.01%     
==========================================
  Files         479      479              
  Lines       38748    38746       -2     
  Branches     5621     5621              
==========================================
- Hits        37300    37296       -4     
- Misses       1406     1408       +2     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua enabled auto-merge (squash) August 26, 2024 07:36
@iuioiua iuioiua merged commit 37d3350 into denoland:main Aug 26, 2024
16 checks passed
@timreichen timreichen deleted the yaml-use-isObject branch December 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants