Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): support expect.not.{arrayContaining,objectContaning,stringContaining,stringMatching} #6138

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

eryue0220
Copy link
Contributor

Part of #3964, support:

  • expect.not.arrayContaining
  • expect.not.objectContaining
  • expect.not.stringContaining
  • expect.not.stringMatching

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (c0427a0) to head (60622bd).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
expect/_asymmetric_matchers.ts 96.87% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6138   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         536      536           
  Lines       40684    40705   +21     
  Branches     6110     6113    +3     
=======================================
+ Hits        39297    39321   +24     
+ Misses       1343     1340    -3     
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eryue0220 eryue0220 marked this pull request as ready for review October 24, 2024 06:39
@eryue0220 eryue0220 requested a review from kt3k as a code owner October 24, 2024 06:39
Comment on lines -72 to -73
* - Asymmetric matchers:
* - `expect.not.objectContaining`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! @eryue0220

@kt3k kt3k merged commit f4fef35 into denoland:main Oct 28, 2024
19 checks passed
@eryue0220 eryue0220 deleted the feat/expect-asymmetric-api branch October 28, 2024 07:14
@kt3k kt3k mentioned this pull request Nov 26, 2024
20 tasks
@dandv
Copy link
Contributor

dandv commented Dec 7, 2024

PTAL? #6243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants