Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(encoding/unstable): Crockford base32 unstable support #6238

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

wesleyakio
Copy link
Contributor

Crockford base32 support as discussed in #6235

File naming is unstable_base32crockford.ts instead of unstable_base32_crockford.ts in order to mimic the already existing unstable_base32hex.ts.

This is a clone of base32/base32hex with the Crockford dictionary and no other changes except for test updates to match the new dictionary.

@wesleyakio wesleyakio requested a review from kt3k as a code owner December 5, 2024 16:50
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (f13db89) to head (53f6f0f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6238      +/-   ##
==========================================
- Coverage   96.52%   96.52%   -0.01%     
==========================================
  Files         534      535       +1     
  Lines       41008    41028      +20     
  Branches     6141     6141              
==========================================
+ Hits        39585    39604      +19     
- Misses       1381     1382       +1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title feat(encoding): Crockford base32 unstable support feat(encoding/unstable): Crockford base32 unstable support Dec 9, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b2b7f99 into denoland:main Dec 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants