-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): align prompt functions #6257
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6257 +/- ##
=======================================
Coverage 96.49% 96.49%
=======================================
Files 536 536
Lines 41179 41186 +7
Branches 6175 6177 +2
=======================================
+ Hits 39734 39744 +10
+ Misses 1403 1400 -3
Partials 42 42 ☔ View full report in Codecov by Sentry. |
} else if ( | ||
paramDoc.kind === "assign" && paramDoc.left.kind === "object" | ||
) { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has undesirable effect in doc rendering.
By using destructuring in parameter, there's no longer options
param in arguments, and @param options
directive becomes unclear about what it documents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Why is it though that deno task lint:docs
allows
std/cli/unstable_prompt_select.ts
Line 41 in cc9a7c0
{ clear }: PromptSelectOptions = {}, |
options: PromptMultipleSelectOptions = {}, |
I will close this in favour of multiple small PRs. |
This PR aligns all cli prompt functions to look and work the same internally.