Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): Fix expect.arrayContaining bug #6271

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

eryue0220
Copy link
Contributor

@eryue0220 eryue0220 commented Dec 15, 2024

This pr is to fix #6243.

@eryue0220 eryue0220 requested a review from kt3k as a code owner December 15, 2024 08:38
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (cc9a7c0) to head (8c8d5f1).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6271   +/-   ##
=======================================
  Coverage   96.49%   96.50%           
=======================================
  Files         536      536           
  Lines       41179    41182    +3     
  Branches     6175     6179    +4     
=======================================
+ Hits        39735    39741    +6     
+ Misses       1401     1398    -3     
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @eryue0220 !

@kt3k kt3k merged commit f977cf9 into denoland:main Dec 17, 2024
19 checks passed
@eryue0220 eryue0220 deleted the fix/expect-containing-api-bug branch December 17, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect.arrayContaining + expect.objectContaining broken
2 participants