Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(log): re-enable doc tests for FileHandler #6321

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented Jan 1, 2025

This PR re-enables doc tests that were disabled in #6183. To avoid publication failures, logs for testing are written to ./_tmp, which is ignored by .gitignore. This PR also removes duplicate examples.

@github-actions github-actions bot added the log label Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (e3dc30a) to head (2cbaab5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6321      +/-   ##
==========================================
- Coverage   96.35%   96.34%   -0.02%     
==========================================
  Files         547      547              
  Lines       41671    41671              
  Branches     6315     6315              
==========================================
- Hits        40151    40146       -5     
- Misses       1479     1484       +5     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uki00a uki00a force-pushed the re-enable-log-file-handler-doc-testing branch 5 times, most recently from c38f194 to 636e70a Compare January 4, 2025 16:57
@uki00a uki00a force-pushed the re-enable-log-file-handler-doc-testing branch from 636e70a to 2cbaab5 Compare January 4, 2025 17:03
@uki00a uki00a marked this pull request as ready for review January 4, 2025 17:13
@uki00a uki00a requested a review from kt3k as a code owner January 4, 2025 17:13
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 5d00af0 into denoland:main Jan 6, 2025
18 checks passed
@uki00a uki00a deleted the re-enable-log-file-handler-doc-testing branch January 6, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants