Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(csv): unstable stringify tests #6337

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

cosmastech
Copy link
Contributor

@cosmastech cosmastech commented Jan 7, 2025

To increase test coverage.

Related to: #3713

@cosmastech cosmastech requested a review from kt3k as a code owner January 7, 2025 13:49
@github-actions github-actions bot added the csv label Jan 7, 2025
@cosmastech cosmastech force-pushed the csv_unstable-stringify branch from 94b0b6c to ee75e63 Compare January 7, 2025 13:50
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (2604b37) to head (8c952a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6337   +/-   ##
=======================================
  Coverage   96.43%   96.44%           
=======================================
  Files         547      547           
  Lines       41812    41812           
  Branches     6347     6348    +1     
=======================================
+ Hits        40321    40325    +4     
+ Misses       1450     1447    -3     
+ Partials       41       40    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmastech cosmastech force-pushed the csv_unstable-stringify branch from ee75e63 to 8c952a1 Compare January 10, 2025 18:13
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 3c1b8e9 into denoland:main Jan 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants