fix(assert): handle __proto__ correctly in assertObjectMatch
#6342
+61
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6342 +/- ##
==========================================
- Coverage 96.43% 96.40% -0.03%
==========================================
Files 547 549 +2
Lines 41812 41851 +39
Branches 6347 6348 +1
==========================================
+ Hits 40322 40348 +26
- Misses 1449 1463 +14
+ Partials 41 40 -1 ☔ View full report in Codecov by Sentry. |
kt3k
reviewed
Jan 14, 2025
kt3k
reviewed
Jan 14, 2025
Comment on lines
+70
to
+71
| const memo = seen.get(a); | ||
| if (memo && (memo === b)) return a; |
There was a problem hiding this comment.
Is this change necessary? What happens if memo is the value false?
There was a problem hiding this comment.
Just performance thing. If you read the context of the changed lines, you'll realize that will never happen.
There was a problem hiding this comment.
See these types: cfbff35
If you say this change should be done in another PR, I understand it and revert this part, but I'd say such a trivial and small change can be okay to come along with...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6341.